Formatting hooks - #38
Merged
Merged
Conversation
Compiling in pre-commit is not a good idea, since it takes forever
CatarinaGamboa
approved these changes
Dec 2, 2024
Collaborator
|
Actually, it might be a good time to apply that repo-wide formatting diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current pre-commit hook is next to useless, as no one uses it. In addition, the repository contains a mixture of formats and indentation.
These commits enable a set of more useful hooks, and the palantir formatter. I have not included a commit reformatting everything (it would be sizeable), but any future commit with pre-commit enabled will obey the formatting.