Skip to content

Special Variable Substitution #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 5 commits into from
Apr 11, 2026
Merged

Special Variable Substitution #201

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
694e7ec
Special Variable Substitution
rcosta358 Apr 1, 2026
1ef22fc
Code Refactoring
rcosta358 Apr 1, 2026
0f47626
Minor Change
rcosta358 Apr 1, 2026
0c83251
Minor Change
rcosta358 Apr 1, 2026
9e0fb1e
Merge branch 'main' into special-variable-substitution
rcosta358 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor Change
  • Loading branch information
@rcosta358
rcosta358 committed Apr 1, 2026
commit 0f47626825f39aa0a1522ae66f1a6fe445739cf8
7 changes: 2 additions & 5 deletions liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VariableResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@

public class VariableResolver {

private static final String RET_PREFIX = "#ret_";
private static final String FRESH_PREFIX = "#fresh_";

/**
* Extracts variables with constant values from an expression
*
Expand Down Expand Up @@ -161,10 +158,10 @@ private static int getCounter(Var var) {
}

private static boolean isReturnVar(Var var) {
return var.getName().startsWith(RET_PREFIX);
return var.getName().startsWith("#ret_");
}

private static boolean isFreshVar(Var var) {
return var.getName().startsWith(FRESH_PREFIX);
return var.getName().startsWith("#fresh_");
Copy link
Copy Markdown
Collaborator

@CatarinaGamboa CatarinaGamboa Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could these be dependent on the final strings where we define the format for fresh and ret instead of hard coded?

Copy link
Copy Markdown
Collaborator Author

@rcosta358 rcosta358 Apr 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically yeah, but not cleanly, since the formats are #ret_%d and #fresh_%d and we only want the prefixes. It would only work with regexes, not string formats.

}
}
Loading