Skip to content

Add #result for Return Refinements #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajshivu wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add #result for Return Refinements #145

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d7e2dc
feat: implement support and restore test infrastructure
Feb 10, 2026
e111574
TestMultiple: restored original
Feb 10, 2026
ab4d600
Assert: checked assert validation tests
Feb 11, 2026
58a5475
Fix refinement handling in rj grammar
Feb 11, 2026
a3bee27
Support as a restricted refinement variable
Feb 13, 2026
515ddf5
Remove commented-out code from CreateASTVisitor
Feb 13, 2026
b38a5fc
Merge branch 'main' into feature-result-refinement
rajshivu Feb 15, 2026
a0edc1f
Remove obsolete code and cleanup comments
rajshivu Feb 15, 2026
4969ce5
resolved the conflict in CreateASTVisitor
rajshivu Feb 15, 2026
98d9760
Update: to #result
rajshivu Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix refinement handling in rj grammar
  • Loading branch information
RajShivu committed Feb 11, 2026
commit 58a547577f3bc7eff8b11f7883ccf86537747743
2 changes: 1 addition & 1 deletion liquidjava-verifier/src/main/antlr4/rj/grammar/RJ.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ BOOL : 'true' | 'false';
ID_UPPER: ([A-Z][a-zA-Z0-9]*);
OBJECT_TYPE:
(([a-zA-Z][a-zA-Z0-9]+) ('.' [a-zA-Z][a-zA-Z0-9]*)+);
ID : '#'*[a-zA-Z_][a-zA-Z0-9_#]*;
ID : '#'*('$')? [a-zA-Z_] [a-zA-Z0-9_#]* ;
Copy link
Copy Markdown
Collaborator

@CatarinaGamboa CatarinaGamboa Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a great idea to change all the IDs to allow the $. We can improve it by only allowing $result and only in the places it can appear (not when a ghost or state is created for example)

STRING : '"'(~["])*'"';
INT : (([0-9]+) | ([0-9]+('_'[0-9]+)*));
REAL : (([0-9]+('.'[0-9]+)?) | '.'[0-9]+);
Expand Down