You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ x ] I have read the contributing guideline and understand that I have made the correct modifications
Description:
I've added a set of ENV variables derived directly from the latest Docker API and matching files for filtering using them.
The ADVANCED env variable selects for the new files which use the new variables.
Issues that I see with this current solution:
Duplication of ENV variables between the regular and advanced modes - solution would likely be just to manually remove the duplicates but I didn't at the time so that they'd keep the 1:1 match with the Docker API
I think it'd be preferable to create a system that automatically updates for any Docker API updates - I created a rough perl script that generates the variables from the API yaml but it's not fit for inclusion and I'm not sure something that automatically edits the dockerfile is desirable or would fit into the current build process
It might be desirable for someone more familiar with the Docker API to double check there is no issues with letting all version through the same filter.
Benefits of this PR and context:
Should close#12 and should tighten up the security of the proxy which currently allows more commands through than probably intended.
How Has This Been Tested?
I did some rough testing by launching a compose with a container built on this change and one that operated as a console.
I then manually sent some curl commands through to try and access a couple allowed and disallowed options.
This was not as thorough as I'd like and should be double checked before merging.
@thespad Does this seem like a proper fix/pull request?
Sorry for pinging, just the original issue this is for was posted 3 weeks ago without response so I'm not sure if it's been noticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I've added a set of ENV variables derived directly from the latest Docker API and matching files for filtering using them.
The
ADVANCEDenv variable selects for the new files which use the new variables.Issues that I see with this current solution:
Benefits of this PR and context:
Should close #12 and should tighten up the security of the proxy which currently allows more commands through than probably intended.
How Has This Been Tested?
I did some rough testing by launching a compose with a container built on this change and one that operated as a console.
I then manually sent some
curlcommands through to try and access a couple allowed and disallowed options.This was not as thorough as I'd like and should be double checked before merging.
Source / References: