Fix dynamic and static linking#329
Merged
Merged
Conversation
arrowd
reviewed
Apr 22, 2026
Contributor
arrowd
left a comment
There was a problem hiding this comment.
Thank you, this fixes the linking problem for me!
Note that I had to do this too:
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index f70a622..d01478e 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -53,7 +53,7 @@ endif()
add_executable(plugin_test plugin_test_main.cpp)
-target_link_libraries(plugin_test linuxdeploy_plugin)
+target_link_libraries(plugin_test linuxdeploy_plugin CImg)
set_target_properties(plugin_test PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/bin")
add_executable(appdir_test appdir_test_main.cpp ../include/linuxdeploy/util/assert.h)
Thanks @arrowd for assisting!
b960302 to
ec9824f
Compare
Member
Author
|
Thanks @arrowd for bringing up the problem and assisting with the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_LINK_DIRECTORIES.html. This should work on any platform. I might try later on FreeBSD.