Don't fail if missing dependency is in excludeLibraryPatterns#226
Closed
remleduff wants to merge 0 commit into
Closed
Don't fail if missing dependency is in excludeLibraryPatterns#226remleduff wants to merge 0 commit into
remleduff wants to merge 0 commit into
Conversation
TheAssassin
approved these changes
Oct 25, 2023
Member
|
Thanks! |
|
Hey, just trying to bring this up. I'm in a similar setup, and I would also like to avoid failing here. Can this be merged? Thanks for your efforts! |
|
Please merge this, I'm running into the same problem. |
Member
|
Hm, I wonder why it wasn't merged back then. After all, I approved it, apparently. It has merge conflicts now, though, that need to be fixed. |
Member
|
Hm, why was this closed now? I've rebased the remote branch... I see. I should have pushed to |
Member
|
Merged in #332. Thanks @remleduff for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're trying to build an AppImage with one specific library that is excluded so that it comes from the host rather than the AppImage, using the --exclude command line option.
However, our CI build systems don't include that library at all, and this fails with:
This is unfortunate, because libcuda.so.1 was excluded, and not expected to be part of the appimage in the first place.
Making this a warning allows our build to succeed, and the resulting AppImage uses libcuda from the host as expected.
(This addresses the issue from #225)