Skip to content

chore: update rusqlite 0.28.0 -> 0.32.1#400

Closed
dpc wants to merge 1 commit into
lightningdevkit:mainfrom
dpc:24-11-08-update-rusqlite
Closed

chore: update rusqlite 0.28.0 -> 0.32.1#400
dpc wants to merge 1 commit into
lightningdevkit:mainfrom
dpc:24-11-08-update-rusqlite

Conversation

@dpc

@dpc dpc commented Nov 8, 2024

Copy link
Copy Markdown

rusqlite 0.28 is 2 years old at this point, and since cargo allows only one version of native dependencies, this creates conflicts with other dependencies that want to use sqlite.

@TheBlueMatt

Copy link
Copy Markdown
Contributor

Sadly this breaks our MSRV...not sure what to do for those who want to use the latest version for some reason...

@dpc

dpc commented Nov 8, 2024

Copy link
Copy Markdown
Author

I see. Rust 1.63 support ... 🙄

@tnull

tnull commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

I see. Rust 1.63 support ... 🙄

@dpc As mentioned elsewhere, we generally try to be relatively conservative with upgrading dependencies, i.e., would only do so if need a new feature or bugfix. If it were to improve things considerably for you we could consider bumping rusqlite up to 0.31 as a one-time thing, but I'm not sure if you'd benefit from that?

@dpc

dpc commented Nov 15, 2024

Copy link
Copy Markdown
Author

Edit: Actually, never mind. I tried that, turns out that there's no way to have conditional sys dependencies because of cargo bug/limitation.

If we were to use conditional compilation, then it should be possible to support multiple rusqlite version at the same time. People who need newer version could just opt-in using a cargo feature, while people who don't could just stick to defaults.

I need to find some time to try a PoC of that.

@dpc

dpc commented Nov 15, 2024

Copy link
Copy Markdown
Author

Closing as redundant. See #403

@dpc dpc closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants