fix: replace Switch with Checkbox for x-axis padding control#23784
Closed
owlas wants to merge 1 commit into
Closed
fix: replace Switch with Checkbox for x-axis padding control#23784owlas wants to merge 1 commit into
owlas wants to merge 1 commit into
Conversation
The toggle pads/extends the numeric x-axis range rather than truncating it, so the previous label was misleading. Also switch the control from a Switch to a Checkbox to match the other axis options in this panel.
8318d85 to
8109997
Compare
Collaborator
Author
|
waiting for preview env |
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-23784 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-23784.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Replaced the
Switchcomponent withCheckboxfor the x-axis padding control in the chart configuration panel. Also updated the label from "Truncate x-axis" to "Extra padding" to better reflect the functionality.This change improves the UI consistency by using the more appropriate
Checkboxcomponent for this binary toggle, and clarifies the control's purpose with a more descriptive label.Changes:
Switchimport from@mantine/coreSwitchcomponent withCheckboxfor x-axis offset controlTest Plan:
No testing needed — this is a UI component replacement with no behavioral changes. The checkbox functions identically to the previous switch implementation.
https://claude.ai/code/session_0173GgERsTQdtMFYre1n85a2