feat: remember preferences for experimental dbt cloud cli#21846
Open
feat: remember preferences for experimental dbt cloud cli#21846
Conversation
Persist the user's acceptance of the dbt Cloud CLI experimental warning to ~/.config/lightdash/config.yaml so they are not prompted on every CLI invocation. Uses the same setAnswer/getConfig pattern as other persisted preferences.
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-21846 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-21846.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
getDbtVersion now imports getConfig/setAnswer, so the test needs to mock ../../config to avoid hitting the filesystem in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/lightdash/config.yamlinstead of only storing it in-memory for the sessionsetAnswer/getConfigpattern already used bypermissionToStoreWarehouseCredentialsandmetadataFileGitignoreNoticeShownTest plan
lightdash compilewith a fake dbt Cloud CLI binaryuseExperimentalDbtCloudCLI: truewritten to config file