fix: support sql_filter in explores config#21841
Merged
Conversation
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-21841 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-21841.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
sql_filter was silently ignored when set inside an `explores` block because the ExploreConfig type and translator logic didn't handle it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8ad83dc to
cc2e902
Compare
Collaborator
|
🎉 This PR is included in version 0.2745.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://linear.app/lightdash/issue/PROD-6867/sql-filter-is-not-working-in-the-explores-config-for-models
Description:
sql_filter was silently ignored when set inside an
exploresblock because the ExploreConfig type and translator logic didn't handle it.Testing:
I tested with "Completed Orders"
Before:
Note: no where clause
After:
Note: "where clause" is present