fix: remove styled-components, replace with CSS modules#21820
Open
owlas wants to merge 1 commit intosnyk/google-major-upgradesfrom
Open
fix: remove styled-components, replace with CSS modules#21820owlas wants to merge 1 commit intosnyk/google-major-upgradesfrom
owlas wants to merge 1 commit intosnyk/google-major-upgradesfrom
Conversation
Removes the styled-components dependency entirely instead of upgrading from v5 to v6. Migrates all 5 files that used styled-components to CSS modules, which is the project's standard styling approach. - ProjectConnectFlow.styles.tsx → CSS module (bounceIn animation) - SqlForm.tsx SqlEditor → CSS module + CSS variables - Table.styles.tsx → CSS module with data-* attribute selectors - CSSProperties imports → react instead of styled-components - ResourceIcon → remove unused StyledComponent type Closes #21607 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-21820 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-21820.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
styled-componentsentirely instead of upgrading from v5 to v6 (which had csstype version conflicts)Changes
ProjectConnectFlow.styles.tsx→ProjectConnectFlow.module.css(bounce animation)SqlForm.tsx→SqlForm.module.css(SQL editor gutter color via CSS variable)Table.styles.tsx→Table.module.css(all 13 styled components → thin wrappers with data-* attribute selectors)CSSPropertiestype imports switched fromstyled-componentstoreactResourceIcon→ removed unusedStyledComponenttype from unionFROZEN_COLUMN_BORDER_COLORandFROZEN_COLUMN_BORDER_WIDTHconstants (values inlined in CSS)Closes
Test plan
🤖 Generated with Claude Code