fix: check active materialization before routing to pre-aggregate#21811
Open
IrakliJani wants to merge 1 commit intomainfrom
Open
fix: check active materialization before routing to pre-aggregate#21811IrakliJani wants to merge 1 commit intomainfrom
IrakliJani wants to merge 1 commit intomainfrom
Conversation
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-21811 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-21811.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
38648c5 to
f7ccff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds validation to ensure pre-aggregate queries only execute when an active materialization exists. The changes include:
preAggregateModeldependency to the PreAggregateStrategy to check for active materializationsgetRoutingDecisionto be async and validate active materializations before routing queries to pre-aggregatesNO_ACTIVE_MATERIALIZATIONwhen a pre-aggregate exists but has no active materializationThis prevents queries from being routed to pre-aggregates that don't have valid materializations available, improving query reliability and error handling.