feat: add configurable filter operator for autocomplete search#21770
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-21770 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-21770.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for configurable filter operators in autocomplete search functionality. Previously, autocomplete searches always used the
INCLUDEoperator, but now users can specifySTARTS_WITHorENDS_WITHoperators for more precise filtering.Key changes:
filterOperatorparameter to theFilterStringAutoCompletecomponent and related hooksgetAutocompleteSearchOperatormethod inProjectServiceto handle operator selection logicfilterOperatorparameteruseFieldValuesanduseFieldValuesSafelyhooks to support the new operator parameterfilterOperatorpropThe autocomplete search now respects the filter operator selected by the user, providing more accurate and relevant suggestions based on whether they want to match values that include, start with, or end with their search term.