refactor: replace convertToUTC boolean with timezone string in formatting functions#21750
Closed
almeidabbm wants to merge 1 commit intomainfrom
Closed
refactor: replace convertToUTC boolean with timezone string in formatting functions#21750almeidabbm wants to merge 1 commit intomainfrom
almeidabbm wants to merge 1 commit intomainfrom
Conversation
This was referenced Apr 3, 2026
Contributor
Author
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-21750 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-21750.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
7212e7e to
552ad79
Compare
b8f0ca8 to
d3ec9da
Compare
d3ec9da to
b93b3ab
Compare
552ad79 to
978992f
Compare
b93b3ab to
d663049
Compare
adf430e to
dc697eb
Compare
c27f64d to
31b2fac
Compare
d663049 to
6e27d27
Compare
31b2fac to
92d6f53
Compare
6e27d27 to
656826f
Compare
e4b6be9 to
81b2790
Compare
656826f to
38359f0
Compare
e865f42 to
4db271a
Compare
4fdb60b to
04fe7b4
Compare
This was referenced Apr 9, 2026
04fe7b4 to
2290c5b
Compare
4db271a to
02a4d14
Compare
02a4d14 to
db9eaad
Compare
2290c5b to
4fe44cf
Compare
4fe44cf to
529df36
Compare
db9eaad to
a6e5181
Compare
a6e5181 to
c6c4d0a
Compare
529df36 to
5dc078d
Compare
c6c4d0a to
846b340
Compare
5dc078d to
097366b
Compare
846b340 to
2b41b2c
Compare
…ting functions Replace `convertToUTC: boolean` with `timezone?: string` in formatDate, formatTimestamp, formatItemValue, formatRow, formatRows, getFormattedValue, and all callers. When timezone is provided, uses moment.utc(value).tz(timezone). When undefined (flag off), uses moment(value) — identical to previous behavior with convertToUTC=false. Callers that passed `true` now pass 'UTC' (same behavior). Callers that passed `false` now pass undefined (same behavior).
Contributor
Author
|
Closing this — we're taking a different approach that keeps the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to: https://linear.app/lightdash/issue/GLITCH-291/update-result-formatting-to-use-resolved-project-timezone
Pure signature refactor — no behavior change.
Replaces
convertToUTC: booleanwithtimezone?: stringinformatDate,formatTimestamp,formatItemValue,formatRow,formatRows,getFormattedValue, and all callers.true→'UTC'(same behavior viamoment.utc())false→undefined(same behavior viamoment())This prepares the formatting stack to accept a project timezone string in the next PR.