test: fix fs_event_watch_file_currentdir flakiness#581
Closed
santigimeno wants to merge 1 commit intolibuv:v1.xfrom
Closed
test: fix fs_event_watch_file_currentdir flakiness#581santigimeno wants to merge 1 commit intolibuv:v1.xfrom
santigimeno wants to merge 1 commit intolibuv:v1.xfrom
Conversation
In FreeBSD 10.2 the test sometimes times out because the "touch file" timer fires before the "watch file" event has been registered in the kqueue. Increasing the timeout value seems to fix the issue.
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 20, 2015
In FreeBSD 10.2 the test sometimes times out because the "touch file" timer fires before the "watch file" event has been registered in the kqueue. Increasing the timeout value seems to fix the issue. PR-URL: #581 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
|
Thanks Santiago, landed in a0e30b5. |
evanlucas
pushed a commit
to evanlucas/libuv
that referenced
this pull request
Dec 5, 2015
In FreeBSD 10.2 the test sometimes times out because the "touch file" timer fires before the "watch file" event has been registered in the kqueue. Increasing the timeout value seems to fix the issue. PR-URL: libuv#581 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FreeBSD 10.2 the test sometimes times out because the "touch file" timer
fires before the "watch file" event has been registered in the kqueue.
Increasing the timeout value seems to fix the issue.