aix: disable ipv6 link local#4229
Merged
bnoordhuis merged 2 commits intolibuv:v1.xfrom Nov 18, 2023
abmusse:aix-disable-ipv6-link-local
Merged
aix: disable ipv6 link local#4229bnoordhuis merged 2 commits intolibuv:v1.xfrom abmusse:aix-disable-ipv6-link-local
bnoordhuis merged 2 commits intolibuv:v1.xfrom
abmusse:aix-disable-ipv6-link-local
Conversation
aix does not implement ifaddrs and when retrieving the network interfaces with uv_interface_addresses there was a test failure in tcp_connect6_link_local. Ref: #4222 (comment) For now disable ipv6 link local on aix to: 1) fix broken aix build 2) stop blocking libuv upgrade in node Ref: nodejs/node#50650
bnoordhuis
reviewed
Nov 17, 2023
Contributor
Author
richardlau
approved these changes
Nov 18, 2023
bnoordhuis
approved these changes
Nov 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aix does not implement ifaddrs and when retrieving the network interfaces with uv_interface_addresses there was a test failure in tcp_connect6_link_local.
Ref: #4222 (comment)
For now disable ipv6 link local on aix to:
Ref: deps: update libuv to 1.47.0 nodejs/node#50650
I've got a PR open to use
uv_interface_addresseson AIX.Ref: #4222
This is still a work in progress and will need more review and testing before merging.
In the meantime, we can skip ipv6 link local on AIX and IBM i to prevent blocking libuv upgrade in node.
CC
@richardlau
@mhdawson
@libuv/ibmi
@libuv/aix