Merged
Conversation
We forgot to mask off the high bits from the first byte, so we ended up always failing the subsequent range check. Refs: libuv#297 Fixes: nodejs/node#48673
Member
Author
|
I don't have an easy way to test this since they aren't exported utilities, but this is the cause of the test failure in #4021, where we do export this. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bnoordhuis
approved these changes
Jul 12, 2023
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
Hrm, gcc's -Wmisleading-indentation should've flagged this. Is our copy of mingw so old it doesn't print anything?
Member
Author
|
The indentation was fine. It was missing the bit mask. |
|
No tests for files with Unicode surrogate pair(s) in names were added?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot to mask off the high bits from the first byte, so we ended up always failing the subsequent range check.
Refs: #2970 (need to fix this in the commit message when merging)
Fixes: nodejs/node#48673