unix: handle invalid _SC_GETPW_R_SIZE_MAX values#389
Closed
cjihrig wants to merge 1 commit intolibuv:v1.xfrom
Closed
unix: handle invalid _SC_GETPW_R_SIZE_MAX values#389cjihrig wants to merge 1 commit intolibuv:v1.xfrom
cjihrig wants to merge 1 commit intolibuv:v1.xfrom
Conversation
Some systems, FreeBSD for example, may return negative values. sysconf() returns a long, which was being converted to a size_t. This conversion lead to large allocations, and subsequent out of memory failures. This commit checks the long value returned by sysconf() properly, and uses a default value of 4096 if a negative number is returned.
Member
|
Ups. I guess we should do a patch release once this lands. |
Member
|
LGTM FWIW. |
saghul
pushed a commit
that referenced
this pull request
Jun 5, 2015
Some systems, FreeBSD for example, may return negative values. sysconf() returns a long, which was being converted to a size_t. This conversion lead to large allocations, and subsequent out of memory failures. This commit checks the long value returned by sysconf() properly, and uses a default value of 4096 if a negative number is returned. PR-URL: #389 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Member
|
Cheers, Colin, landed in d82e47a. |
guworks
pushed a commit
to guworks/libuv
that referenced
this pull request
Jul 9, 2015
Some systems, FreeBSD for example, may return negative values. sysconf() returns a long, which was being converted to a size_t. This conversion lead to large allocations, and subsequent out of memory failures. This commit checks the long value returned by sysconf() properly, and uses a default value of 4096 if a negative number is returned. PR-URL: libuv#389 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
skomski
pushed a commit
to skomski/libuv
that referenced
this pull request
Aug 5, 2015
Some systems, FreeBSD for example, may return negative values. sysconf() returns a long, which was being converted to a size_t. This conversion lead to large allocations, and subsequent out of memory failures. This commit checks the long value returned by sysconf() properly, and uses a default value of 4096 if a negative number is returned. PR-URL: libuv#389 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
skomski
pushed a commit
to skomski/libuv
that referenced
this pull request
Aug 5, 2015
Some systems, FreeBSD for example, may return negative values. sysconf() returns a long, which was being converted to a size_t. This conversion lead to large allocations, and subsequent out of memory failures. This commit checks the long value returned by sysconf() properly, and uses a default value of 4096 if a negative number is returned. PR-URL: libuv#389 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some systems, FreeBSD for example, may return negative values.
sysconf()returns a long, which was being converted to asize_t. This conversion lead to large allocations, and subsequent out of memory failures. This commit checks the long value returned bysysconf()properly, and uses a default value of 4096 if a negative number is returned.Related to nodejs/node#1791
R=@bnoordhuis