win: fail fs_open with append and file mapping#2448
Closed
joaocgreis wants to merge 1 commit intolibuv:v1.xfrom
Closed
win: fail fs_open with append and file mapping#2448joaocgreis wants to merge 1 commit intolibuv:v1.xfrom
joaocgreis wants to merge 1 commit intolibuv:v1.xfrom
Conversation
4 tasks
Member
|
@libuv/collaborators This needs a decision. |
Member
|
I don't have a stong opinion, but the concept of "appending" to a memory mapped file feels linda awkward to me, so I'm +1 to landing this PR. There is, however, some irony in that we are aligning the behavior with Unix but we don't support that flag there yet :-) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bnoordhuis suggested in nodejs/node#29260 (comment) that
uv_fs_openshould fail withEACCESwhen bothO_APPENDandUV_FS_O_FILEMAPare specified. This is an implementation of that suggestion.I would rather keep the current behavior and not land this PR, but don't have strong feelings.
uv_fs_readanduv_fs_writeis exactly the same with or withoutUV_FS_O_FILEMAP. The code to support this is very small, and I suspect supporting this in Unix would also require little code - an unexpected but useful extension.uv_fs_openbehaves more like what would be expected of a Unix implementation, by failing.I'll leave the decision for the libuv maintainers.