Skip to content

win: support retrieving empty env variables#2419

Merged
cjihrig merged 3 commits intolibuv:v1.xfrom
cjihrig:envvar
Aug 13, 2019
Merged

win: support retrieving empty env variables#2419
cjihrig merged 3 commits intolibuv:v1.xfrom
cjihrig:envvar

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Aug 12, 2019

Fixes: #2413

@cjihrig cjihrig mentioned this pull request Aug 12, 2019
Closed
@cjihrig
Copy link
Copy Markdown
Contributor Author

cjihrig commented Aug 12, 2019

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1524/

saghul
saghul reviewed Aug 12, 2019
View reviewed changes
Comment thread src/win/util.c
@cjihrig
Copy link
Copy Markdown
Contributor Author

cjihrig commented Aug 12, 2019

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1526/. None of the failures look related.

@erw7 erw7 mentioned this pull request Aug 13, 2019
Closed
saghul
saghul approved these changes Aug 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

cjihrig added 3 commits August 13, 2019 10:56
@cjihrig
win: map ERROR_ENVVAR_NOT_FOUND to UV_ENOENT
b0fd171 
Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrig
win: use L'\0' as UTF-16 null terminator
6c9c4fe 
uv__convert_utf8_to_utf16() always null terminates its
UTF-16 output. This commit updates the code to use L'\0'
as the terminator, instead of '\0'.

Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrig
win: support retrieving empty env variables
9e80057 
This commit adds Windows support for retrieving empty
environment variables via uv_os_getenv().

Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrig cjihrig merged commit 9e80057 into libuv:v1.x Aug 13, 2019
@cjihrig cjihrig deleted the envvar branch August 13, 2019 14:58
@addaleax addaleax mentioned this pull request Aug 18, 2019
Closed
3 tasks
erw7 pushed a commit to erw7/libuv that referenced this pull request Aug 19, 2019
@cjihrig @erw7
win: support retrieving empty env variables
61ba62f 
This commit adds Windows support for retrieving empty
environment variables via uv_os_getenv().

Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7 pushed a commit to erw7/libuv that referenced this pull request Aug 19, 2019
@cjihrig @erw7
win: use L'\0' as UTF-16 null terminator
134dff5 
uv__convert_utf8_to_utf16() always null terminates its
UTF-16 output. This commit updates the code to use L'\0'
as the terminator, instead of '\0'.

Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7 pushed a commit to erw7/libuv that referenced this pull request Aug 19, 2019
@cjihrig @erw7
win: map ERROR_ENVVAR_NOT_FOUND to UV_ENOENT
f16bcf5 
Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7 pushed a commit to erw7/libuv that referenced this pull request Aug 19, 2019
@cjihrig @erw7
win: support retrieving empty env variables
1876786 
This commit adds Windows support for retrieving empty
environment variables via uv_os_getenv().

Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7 pushed a commit to erw7/libuv that referenced this pull request Aug 19, 2019
@cjihrig @erw7
win: use L'\0' as UTF-16 null terminator
68e8d34 
uv__convert_utf8_to_utf16() always null terminates its
UTF-16 output. This commit updates the code to use L'\0'
as the terminator, instead of '\0'.

Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7 pushed a commit to erw7/libuv that referenced this pull request Aug 19, 2019
@cjihrig @erw7
win: map ERROR_ENVVAR_NOT_FOUND to UV_ENOENT
b2463aa 
Fixes: libuv#2413
PR-URL: libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@addaleax addaleax mentioned this pull request Aug 20, 2019
Closed
2 tasks
@erw7 erw7 mentioned this pull request Sep 11, 2019
Merged
1 task
@bobbrow bobbrow mentioned this pull request Dec 27, 2019
Closed
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
@cjihrig @liujinye-sys
win: map ERROR_ENVVAR_NOT_FOUND to UV_ENOENT
9cf781d 
Fixes: libuv/libuv#2413
PR-URL: libuv/libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
@cjihrig @liujinye-sys
win: use L'\0' as UTF-16 null terminator
b7126a6 
uv__convert_utf8_to_utf16() always null terminates its
UTF-16 output. This commit updates the code to use L'\0'
as the terminator, instead of '\0'.

Fixes: libuv/libuv#2413
PR-URL: libuv/libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
@cjihrig @liujinye-sys
win: support retrieving empty env variables
d3c31e0 
This commit adds Windows support for retrieving empty
environment variables via uv_os_getenv().

Fixes: libuv/libuv#2413
PR-URL: libuv/libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
@cjihrig @openvela-robot
win: map ERROR_ENVVAR_NOT_FOUND to UV_ENOENT
6faa9ae 
Fixes: libuv/libuv#2413
PR-URL: libuv/libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
@cjihrig @openvela-robot
win: use L'\0' as UTF-16 null terminator
2b234c3 
uv__convert_utf8_to_utf16() always null terminates its
UTF-16 output. This commit updates the code to use L'\0'
as the terminator, instead of '\0'.

Fixes: libuv/libuv#2413
PR-URL: libuv/libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
@cjihrig @openvela-robot
win: support retrieving empty env variables
8362c86 
This commit adds Windows support for retrieving empty
environment variables via uv_os_getenv().

Fixes: libuv/libuv#2413
PR-URL: libuv/libuv#2419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@saghul saghul saghul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows: uv_os_getenv() with empty (but defined) variable

3 participants

@cjihrig @bnoordhuis @saghul