Closed
Conversation
cjihrig
reviewed
Jun 13, 2018
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
Shouldn't this go in the API docs?
8cb2558 to
d11bb6c
Compare
Contributor
Author
|
my bad, yes. Fixed |
cjihrig
approved these changes
Jun 13, 2018
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
The error should be UV_EBADF (probably in backticks). And, if it's still an AIX specific note, it should say that. But LGTM.
Unlike other platforms, the fsync call on aix will not accept non-regular file file-descriptors.
richardlau
approved these changes
Jun 13, 2018
4 tasks
cjihrig
pushed a commit
that referenced
this pull request
Jun 19, 2018
Unlike other platforms, the fsync call on aix will not accept non-regular file file-descriptors. Refs: nodejs/node#21298 PR-URL: #1879 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Contributor
|
Landed in 8ab14e2. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike other platforms, the fsync call on aix will not accept non-regular
file file-descriptors.