test: regression test for Node issue #20112#1818
Closed
bzoz wants to merge 2 commits intolibuv:v1.xfrom
Closed
Conversation
Port test from nodejs/node#20138 to libuv. Refs: nodejs/node#20112 Refs: nodejs/node#20138
Member
Author
cjihrig
reviewed
Apr 27, 2018
| Based on Node.js test from | ||
| https://github.com/nodejs/node/commit/3ba81e34e86a5c32658e218cb6e65b13e8326bc5 | ||
|
|
||
| If anything goes wrong, you can delte the test_fle_icacls with: |
Contributor
There was a problem hiding this comment.
delte -> delete?
test_fle_icacls -> test_file_icacls?
|
|
||
| #ifdef _WIN32 | ||
| int call_icacls(const char* command, ...) { | ||
| char icacls_command[1024]; |
Contributor
There was a problem hiding this comment.
The indentation of this whole PR seems off.
Member
Author
|
Test ended up as part of #1819 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port test from nodejs/node#20138 to libuv.
Refs: nodejs/node#20112
Refs: nodejs/node#20138