Support for direct-streamlocal@openssh.com UNIX socket connection#216
Support for direct-streamlocal@openssh.com UNIX socket connection#216gjalves wants to merge 4 commits intolibssh2:masterfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This looks like the travis build failed due to some internal issue in the test suite? |
|
I think travis is mumbling about cosmetic aspects, like line lengths and misplaced spaces. I'll review this patch to overcome those errors. |
|
Yeah, I can see that now, its failing on the command |
|
Is this allowed to be merged now? |
| return LIBSSH2_ERROR_BAD_USE; | ||
|
|
||
| if(!channel->session) | ||
| return LIBSSH2_ERROR_SOCKET_RECV; |
There was a problem hiding this comment.
Can you explain the reason for this check? As far as I understand, there should never be a channel with a NULL session.
Also, the choice of error code here seems odd. Why return this error code?
There was a problem hiding this comment.
This check is unrelated with this patch and was wrongly pushed. I've stomped with channel->session == NULL and put this check to came along without crash, but I do not know why this error happened. I got the same impression that is an impossible situation, but I do not bothered to go deeper.
There was a problem hiding this comment.
Unless I'm misunderstanding something, should we delete this check if it isn't related to this PR, or is this something we need?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Could you please add documentation for this new API when you get a chance? Thanks! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@willco007 Sorry to be a pest, but this looks like its done now and can be merged? |
|
Agreed this looks ready for merging. |
|
The |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'd like to land this, but we're still waiting for final update to the CMakeLists. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hello there good day!
is the rewrite ready? |
|
This would need a rebase and |
| const char *socket_path, | ||
| const char *shost, int sport); |
There was a problem hiding this comment.
I'd be nice to align these.
| const char *socket_path, | |
| const char *shost, int sport); | |
| const char *socket_path, | |
| const char *shost, int sport); |
This patch allow to use direct-streamlocal service from OpenSSH 6.7, that allows UNIX socket connections. Mods: - delete unrelated condition: Ref: #216 (comment) - rebase on master, whitespace updates. Patch-by: @gjalves Gustavo Junior Alves Closes #216 Closes #632 Closes #945
…bssh2#945) This patch allow to use direct-streamlocal service from OpenSSH 6.7, that allows UNIX socket connections. Mods: - delete unrelated condition: Ref: libssh2#216 (comment) - rebase on master, whitespace updates. Patch-by: @gjalves Gustavo Junior Alves Closes libssh2#216 Closes libssh2#632 Closes libssh2#945
This patch allow to use direct-streamlocal service from OpenSSH 6.7, that allows UNIX socket connections.