Skip to content

Request for review - #29

Closed
nulltoken wants to merge 21 commits into
libgit2:masterfrom
nulltoken:vNext
Closed

Request for review#29
nulltoken wants to merge 21 commits into
libgit2:masterfrom
nulltoken:vNext

Conversation

@nulltoken

Copy link
Copy Markdown
Member
  • Update libgit2 binaries to f02f4b5
  • Ensure a CommitCollection can not be built from an unknown sha or a corrupted reference
  • Fix Repository.Info.IsEmpty
  • Fix implementation to cope with improved reference resolving.
  • Fix some issues pinpointed by Code Analysis
  • Fix default CommitCollection sorting behavior
  • Fix creation of reference to prevent it from choking on corrupted ones
  • Enforce CommitEnumerator immutability
  • Add some tests
  • Add some documentation
  • Minor refactorings

nulltoken added 21 commits May 14, 2011 22:29
Fix implementation to cope with improved reference resolving.
Removed SetLastError decorator from bound methods as libigit2 doesn't rely on this mechanism (and probably won't, as there's no POSIX equivalent)
… of a git repositories

Credit goes to @yysun for having spotted these misleading areas
According to git log man page, by default, the commits are ordered in reverse chronological order.
The branch "deadbeef" points to a object which doesn't exist in the repository.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, deadbeef!

@tclem

tclem commented May 19, 2011

Copy link
Copy Markdown
Member

Cool beans. Looks good.

@nulltoken

Copy link
Copy Markdown
Member Author

Merged into vNext

@nulltoken nulltoken closed this May 20, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants