Explore moving the command-simulating methods to their own namespace#1248
Explore moving the command-simulating methods to their own namespace#1248carlosmn wants to merge 1 commit into
Conversation
A lot of the methods on Repository are actually trying to replicate git commands, which makes it harder to see what's the operation vs command. Move them to their own namespace to make it clear what they're trying to achieve. We start with a few forms of the git-checkout command.
|
This is very nice! The only feature missing from the class is progress reporting! 😄 |
|
Progress reporting is going to be interesting if we want to use the same output as git. We can ask the user for a |
|
@carlosmn that is one option, another option is to return a streaming data structure which contains all of the relevant information. Should not be difficult to produce a structure which supports lines, colors, etc. |
Just a brainstorming idea, but could a callback (delegate) work for progress reporting? It would fit quite well into GUI's I think, while a CUI implementation would be "obvious". |
|
Superseded by #1294 |
A lot of the methods on Repository are actually trying to replicate git
commands, which makes it harder to see what's the operation vs command.
Move them to their own namespace to make it clear what they're trying to
achieve. We start with a few forms of the git-checkout command.
This shows a possible implementation of this. The
Checkout()methods on Repository would still need to get deprecated, but they depend on each other in weird ways so we can figure that out if and when we decide to go forward with it.The library itself should also likely get a similar treatment, but it's a lot more annoying to do anything in C, so we start here.
/cc @nulltoken @jamill @whoisj