Repository navigation
Conversation
setup_fixture_worktree opens its repositories with cl_git_sandbox_init and cleanup_fixture_worktree frees them, but clar still points at the last one. A later cleanup that calls cl_git_sandbox_cleanup before the next cl_git_sandbox_init frees it again: running worktree::open and then network::fetchlocal under ASan reports a heap-use-after-free. Add cl_git_sandbox_init_unmanaged, which sets up a sandbox that the caller frees and removes, leaving the one clar tracks alone, and use it for the fixture's repositories.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup_fixture_worktreeopens its repositories withcl_git_sandbox_init, andcleanup_fixture_worktreefrees them, but clar still points at the last one. A later cleanup that callscl_git_sandbox_cleanupbefore the nextcl_git_sandbox_initfrees it again. Runningworktree::openand thennetwork::fetchlocalunder ASan reports a heap-use-after-free.This adds
cl_git_sandbox_init_unmanaged, which sets up a sandbox that the caller frees and removes, leaving the one clar tracks alone, and uses it for the fixture's repositories.#7409 fixes the same problem in three individual tests, one of them in
worktree::worktree. The two changes are independent, and with both, every worktree suite followed bynetwork::fetchlocalis clean under ASan.