Skip to content

export all internal git functions - #7296

Draft
milahu wants to merge 114 commits into
libgit2:mainfrom
milahu:export-all-git-functions
Draft

export all internal git functions#7296
milahu wants to merge 114 commits into
libgit2:mainfrom
milahu:export-all-git-functions

Conversation

@milahu

@milahu milahu commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown

probably this will never get merged → draft PR

i needed some internal functions

git_iterator_for_tree
git_iterator_current
git_iterator_advance
git_iterator_free

to build a custom version of git_diff_tree_to_tree
for my git-file-times
where i dont need full tree diffs
but i only need to know "was this file added or modified or renamed"

so i exported all the internal git_* functions

in 8882239 i fixed a typecast for C++

seems to work... at least on linux
build is passing, tests are passing, downstream build is passing

edit: fixme:

In file included from /home/libgit2/source/tests/libgit2/apply/apply_helpers.c:1:
/home/libgit2/source/tests/libgit2/apply/apply_helpers.c: In function 'validate_index_unchanged':
/home/libgit2/source/tests/libgit2/apply/apply_helpers.c:92:21: error: implicit declaration of function 'git_repository_head_tree'; did you mean 'git_repository_oid_type'? [-Werror=implicit-function-declaration]
   92 |         cl_git_pass(git_repository_head_tree(&head, repo));
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~

maybe caused by a broken include

milahu added 30 commits June 14, 2026 15:45
@milahu
iterator.h: move to git2/iterator.h
e71f612
@milahu
iterator.h: export functions
9c3ad29
@milahu
vector.h: move to git2/vector.h
31b59ae
@milahu
str.h: move to git2/str.h
cda8ad2
@milahu
iterator: fix
960c642
@milahu
str: fix includes
13826e1
@milahu
vector: fix includes
df2075b
@milahu
tests: define GIT_REFS_HEADS_DIR
0af0dfe
@milahu
tests: define GIT_MERGE_HEAD_FILE
3421fc7
@milahu
tests: define git_repository
4585b45
@milahu
git2_util.h: move to git2/git2_util.h
223e74c
@milahu
git2_util.h: fix includes
e81099d
@milahu
git2_util.h: fix includes
e0a3df3
@milahu
git2_features.h: fix includes
361607a
@milahu
git2_features.h: move to git2/git2_features.h
5842af6
@milahu
git2_features.h: move to git2/git2_features.h
08d1d50
@milahu
git2_features.h: move to git2/git2_features.h
d799cbd
@milahu
git2_features.h: move to git2/git2_features.h
44a4236
@milahu
cc-compat.h: move to git2/cc-compat.h
ad59507
@milahu
thread.h: move to git2/thread.h
56792b6
@milahu
unix/pthread.h: move to git2/unix/pthread.h
7b99fff
@milahu
unix/pthread.h: move to git2/unix/pthread.h
5d70b8d
@milahu
unix/pthread.h: move to git2/unix/pthread.h
78ea2a3
@milahu
add move-headers.sh
cd11da2
@milahu
alloc.h: move to git2/alloc.h
013b176
@milahu
array.h: move to git2/array.h
55416cb
@milahu
assert_safe.h: move to git2/assert_safe.h
f88e91e
@milahu
bitvec.h: move to git2/bitvec.h
031e37b
@milahu
ctype_compat.h: move to git2/ctype_compat.h
26ec2c6
@milahu
date.h: move to git2/date.h
78e56f8
milahu added 28 commits June 14, 2026 17:28
@milahu
win32/posix.h: move to git2/win32/posix.h
5b53832
@milahu
win32/precompiled.h: move to git2/win32/precompiled.h
87ab1a3
@milahu
win32/version.h: move to git2/win32/version.h
98ae0a9
@milahu
win32/thread.h: move to git2/win32/thread.h
cd8e8d5
@milahu
win32/msvc-compat.h: move to git2/win32/msvc-compat.h
92d095a
@milahu
win32/w32_util.h: move to git2/win32/w32_util.h
f86e5b5
@milahu
win32/reparse.h: move to git2/win32/reparse.h
e592724
@milahu
win32/win32-compat.h: move to git2/win32/win32-compat.h
d482a71
@milahu
allocators/debugalloc.h: fix includes
5b7feaa
@milahu
allocators/failalloc.h: fix includes
a886737
@milahu
allocators/stdalloc.h: fix includes
baa2e07
@milahu
allocators/win32_leakcheck.h: fix includes
2601168
@milahu
hash/collisiondetect.h: fix includes
2424334
@milahu
hash/sha1dc/sha1.h: fix includes
0b8b6af
@milahu
hash/sha1dc/ubc_check.h: fix includes
6c85021
@milahu
hash/openssl.h: fix includes
525083d
@milahu
export all git_* functions
1eb1bfb
@milahu
add export-all-git-functions.sh
86b5c9d
@milahu
includes: add GIT_END_DECL footers
f97b0fc
@milahu
win32/w32_leakcheck.h: add empty line before GIT_END_DECL footer
cc76c29
@milahu
add add-end-decl-footer.sh
246f92f
@milahu
assert_safe.h: remove GIT_END_DECL footer
ea43fd5
@milahu
sys/cred.h: remove GIT_END_DECL footer
9aa5496
@milahu
includes: add GIT_BEGIN_DECL headers
0e63c39
@milahu
deprecated.h: remove duplicate GIT_END_DECL footer
17633fd
@milahu
vector.h: remove C++ keyword new
ebaa1b2
@milahu
patch.h: remove duplicate GIT_END_DECL footer
b280b88
@milahu
fix: error: invalid conversion from ‘unsigned int’ to ‘git_iterator_f…
8882239 
…lag_t’
@ethomson

ethomson commented Jun 25, 2026

Copy link
Copy Markdown
Member

Instead of trying to make everything internal be external, can we create a simpler API that can provide the information that you're looking for directly?

@milahu

milahu commented Jun 26, 2026

Copy link
Copy Markdown
Author

i have abandoned this path
in favor of a compare_tree_nway function
which does a merge walk of multiple git trees
(the parent trees of merge commits)
to emit "add blob" and "delete blob" events
based on

git_tree_lookup
git_tree_entrycount
git_tree_entry_byindex
git_tree_entry_name
git_tree_entry_type
git_tree_entry_id

so this problem is solvable without the git_iterator_* functions

my current solution is already 20 times faster than git_diff_tree_to_tree
(1000 commits/second versus 50 commits/second)

having the git_iterator_* functions in the public API
would only be interesting if they offer better performance
than the git_tree_entry_* functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milahu @ethomson