Skip to content

config_file: refresh when creating an iterator #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethomson merged 4 commits into from
Jul 22, 2019
Merged

config_file: refresh when creating an iterator #5181

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28d11b5
config_file: consistently use `GIT_CONTAINER_OF`
pks-t Jul 21, 2019
9fac8b7
config_file: do not refresh read-only backends
pks-t Jul 21, 2019
2766b92
config_file: refresh when creating an iterator
pks-t Jul 21, 2019
a213fec
tests: remote: add test suite to test listing remotes
Mr-Wallet Jul 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tests: remote: add test suite to test listing remotes 
There was a bug when calling `git_remote_list` that caused us to not
re-read modified configurations when using `git_config_iterator`. This
bug also impacted `git_remote_list`, which thus failed to provide an
up-to-date list of remotes. Add a test suite remote::list with a single
test that verifies we do the right thing.
  • Loading branch information
@Mr-Wallet @pks-t
Mr-Wallet authored and pks-t committed Jul 21, 2019
commit a213fec64cb818d6a9538dd3682f7ef28693dd35
43 changes: 43 additions & 0 deletions tests/remote/list.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
#include "clar_libgit2.h"
#include "config/config_helpers.h"

static git_repository *_repo;

#define TEST_URL "http://github.com/libgit2/libgit2.git"

void test_remote_list__initialize(void)
{
_repo = cl_git_sandbox_init("testrepo");
}

void test_remote_list__cleanup(void)
{
cl_git_sandbox_cleanup();
}

void test_remote_list__always_checks_disk_config(void)
{
git_repository *repo;
git_strarray remotes;
git_remote *remote;

cl_git_pass(git_repository_open(&repo, git_repository_path(_repo)));

cl_git_pass(git_remote_list(&remotes, _repo));
cl_assert_equal_sz(remotes.count, 1);
git_strarray_free(&remotes);

cl_git_pass(git_remote_create(&remote, _repo, "valid-name", TEST_URL));

cl_git_pass(git_remote_list(&remotes, _repo));
cl_assert_equal_sz(remotes.count, 2);
git_strarray_free(&remotes);

cl_git_pass(git_remote_list(&remotes, repo));
cl_assert_equal_sz(remotes.count, 2);
git_strarray_free(&remotes);

git_repository_free(repo);
git_remote_free(remote);
}