cmake: default NTLM client to off if no HTTPS support#5124
Merged
ethomson merged 1 commit intolibgit2:masterfrom Jun 17, 2019
Merged
cmake: default NTLM client to off if no HTTPS support#5124ethomson merged 1 commit intolibgit2:masterfrom
ethomson merged 1 commit intolibgit2:masterfrom
Conversation
If building libgit2 with `-DUSE_HTTPS=NO`, then CMake will generate an error complaining that there's no usable HTTPS backend for NTLM. In fact, it doesn't make sense to support NTLM when we don't support HTTPS. So let's should just have NTLM default to OFF when HTTPS is disabled to make life easier and to fix our OSSFuzz builds failing.
7addced to
393fb8a
Compare
pks-t
commented
Jun 17, 2019
| OPTION(USE_NTLMCLIENT "Enable NTLM support on Unix." OFF ) | ||
| ELSE() | ||
| OPTION(USE_NTLMCLIENT "Enable NTLM support on Unix." ON ) | ||
| ENDIF() |
Member
Author
There was a problem hiding this comment.
It's quite verbose, but as far as I know there's no other way to do it due to USE_HTTPS accepting not only ON/OFF, but specific backends, too.
Member
|
Makes sense. |
ethomson
approved these changes
Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If building libgit2 with
-DUSE_HTTPS=NO, then CMake willgenerate an error complaining that there's no usable HTTPS
backend for NTLM. In fact, it doesn't make sense to support NTLM
when we don't support HTTPS. So let's should just have
NTLM default to OFF when HTTPS is disabled to make life easier
and to fix our OSSFuzz builds failing.