Change API instances of fromnoun to from_noun (with an underscore)#5117
Merged
Change API instances of fromnoun to from_noun (with an underscore)#5117
fromnoun to from_noun (with an underscore)#5117Conversation
The only function that is named `issomething` (without underscore) was `git_oid_iszero`. Rename it to `git_oid_is_zero` for consistency with the rest of the library.
The majority of functions are named `from_something` (with an underscore) instead of `fromsomething`. Update the blob functions for consistency with the rest of the library.
Member
Author
|
Note that I didn't touch the |
The majority of functions are named `from_something` (with an underscore) instead of `fromsomething`. Update the index functions for consistency with the rest of the library.
The majority of functions are named `from_something` (with an underscore) instead of `fromsomething`. Update the tag function for consistency with the rest of the library.
a5984bf to
e45350f
Compare
Member
At least not the |
pks-t
approved these changes
Jun 16, 2019
Member
pks-t
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for all the interface cleanups you've been doing lately!
This was referenced Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were inconsistent in our API naming, sometimes using
git_object_fromnounand sometimes usinggit_object_from_noun.The majority of functions are named
from_something(with an underscore) instead offromsomething. Update the functions for consistency with the rest of the library.