rebase: orig_head and onto accessors#5057
Merged
ethomson merged 1 commit intolibgit2:masterfrom May 12, 2019
eaigner:merge-rebase-onto-name
Merged
rebase: orig_head and onto accessors#5057ethomson merged 1 commit intolibgit2:masterfrom eaigner:merge-rebase-onto-name
ethomson merged 1 commit intolibgit2:masterfrom
eaigner:merge-rebase-onto-name
Conversation
The rebase struct stores fields with information about the current rebase process, which were not accessible via a public interface. Accessors for getting the `orig_head` and `onto` branch names and object ids have been added.
ethomson
reviewed
Apr 22, 2019
Contributor
|
Since you're poking around interactive rebase, this is my own poke around the rebase code. Started last year, quickly rebased, may contain hazardous material, YMMV. |
tiennou
reviewed
Apr 23, 2019
Author
|
I reverted it to the original approach, since annotated commits seem overkill to me and I think its better to reflect the actual files on disk without having some voodoo magic inbetween. I left the string accessors with So the interface looks like this again: |
Member
|
LGTM. Thanks @eaigner! |
Author
|
🎉😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebase struct stores fields with information about the current
rebase process, which were not accessible via a public interface.
Accessors for getting the
orig_headandontobranchnames and object ids have been added.