Make stdalloc__reallocarray call stdalloc__realloc#4986
Merged
pks-t merged 1 commit intolibgit2:masterfrom Feb 20, 2019
Merged
Conversation
This change avoids calling realloc(3) in more than one place.
Member
What's the advantage of avoiding that? |
Contributor
Author
|
consistency, i guess. all the other functions try to delegate the calls to the underlying libc function as much as possible. |
Member
|
/cc @pks-t |
pks-t
approved these changes
Feb 20, 2019
Member
pks-t
left a comment
There was a problem hiding this comment.
Makes sense to me. Like this, it'd even be possible to swap out e.g. only the stdalloc_realloc function to modify behaviour of both stdalloc_realloc and stdalloc_reallocarray.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change avoids calling realloc(3) in more than one place.