Conversation
Mark old object type values as `static const` so that we can mark them as deprecated with the `GIT_DEPRECATED` macro.
We use the term "invalid" to refer to bad or malformed data, eg `GIT_REF_INVALID` and `GIT_EINVALIDSPEC`. Since we're changing the names of the `git_object_t`s in this release, update it to be `GIT_OBJECT_INVALID` instead of `BAD`.
Update some missed types that were continuing to use the old `GIT_OBJ` names.
055bf97 to
8315101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some further tweaks on moving to
git_object. We use the term "invalid" to refer to bad or malformed data, egGIT_REF_INVALIDandGIT_EINVALIDSPEC. Since we're changing the names of thegit_object_ts in this release, update it to beGIT_OBJECT_INVALIDinstead ofBAD.Per @tiennou's note in #4917, I've also updated the compatibility declarations to be
static const ints instead of#defines, allowing us to mark them as deprecated usingGIT_DEPRECATED.Doing so illustrated some places where we were continuing to use the old names internally; they've also been updated.