Fix warning 'function': incompatible types - from 'git_cvar_value *' to 'int *' (C4133) on VS#4926
Merged
ethomson merged 1 commit intolibgit2:masterfrom Jan 9, 2019
csware:warning-c4133
Merged
Fix warning 'function': incompatible types - from 'git_cvar_value *' to 'int *' (C4133) on VS#4926ethomson merged 1 commit intolibgit2:masterfrom csware:warning-c4133
ethomson merged 1 commit intolibgit2:masterfrom
csware:warning-c4133
Conversation
Member
|
This error message sounds like what MSVC prints when it doesn't know about a type and thus it defaults to |
…to 'int *' (C4133) on VS Signed-off-by: Sven Strickroth <email@cs-ware.de>
Member
|
I'm okay with taking this to squash the warning, but at a glance, I don't know why |
Member
|
Since this is a config cache, sometimes the values that we're caching are actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other places don't use git_cvar_value as type.