Fix type confusion in git_smart__connect#4695
Merged
pks-t merged 1 commit intolibgit2:masterfrom Jun 25, 2018
Merged
Conversation
Nothing verifies that t->refs[0] is a GIT_PKT_REF. A remote can send another packet type, ultimately resulting in a type confusion in `git_smart__detect_caps`
pks-t
reviewed
Jun 25, 2018
|
|
||
| first = (git_pkt_ref *)git_vector_get(&t->refs, 0); | ||
| pkt = (git_pkt *)git_vector_get(&t->refs, 0); | ||
| if (pkt && GIT_PKT_REF != pkt->type) { |
Member
There was a problem hiding this comment.
We usually check the other way round, with the constant on the right-hand side. But here you seem to simply be adhering to style of surrounding code, so this is okay
Member
|
Thanks for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing verifies that t->refs[0] is a GIT_PKT_REF. A remote can send
another packet type, ultimately resulting in a type confusion in
git_smart__detect_caps.This was found by an oss-fuzz integration I'm working on.