Skip to content

Leak fixes for v0.27.1#4635

Merged
pks-t merged 3 commits intolibgit2:masterfrom
tiennou:fix/leaks-v0.27.1
Apr 20, 2018
Merged

Leak fixes for v0.27.1#4635
pks-t merged 3 commits intolibgit2:masterfrom
tiennou:fix/leaks-v0.27.1

Conversation

@tiennou
Copy link
Copy Markdown
Contributor

@tiennou tiennou commented Apr 20, 2018

This fixes the 2 Valgrind-reported leaks that can be backported to v0.27.1

tiennou added 2 commits April 20, 2018 19:17
Valgrind log :

==17702== 18 bytes in 1 blocks are indirectly lost in loss record 69 of 1,123
==17702==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==17702==    by 0x5FDBB49: strdup (strdup.c:42)
==17702==    by 0x632B3E: git__strdup (util.h:106)
==17702==    by 0x632D2C: git_reference__alloc_symbolic (refs.c:64)
==17702==    by 0x62E0AF: loose_lookup (refdb_fs.c:408)
==17702==    by 0x62E636: refdb_fs_backend__iterator_next (refdb_fs.c:565)
==17702==    by 0x62CD8E: git_refdb_iterator_next (refdb.c:147)
==17702==    by 0x6347F2: git_reference_next (refs.c:838)
==17702==    by 0x6345CB: git_reference_foreach (refs.c:748)
==17702==    by 0x66BE62: local_download_pack (local.c:579)
==17702==    by 0x5DB48F: git_fetch_download_pack (fetch.c:148)
==17702==    by 0x639028: git_remote_download (remote.c:932)
==17702==    by 0x63919A: git_remote_fetch (remote.c:969)
==17702==    by 0x4ABEDD: test_fetchhead_nonetwork__fetch_into_repo_with_symrefs (nonetwork.c:362)
==17702==    by 0x4125D9: clar_run_test (clar.c:222)
==17702==    by 0x41287C: clar_run_suite (clar.c:286)
==17702==    by 0x412DDE: clar_test_run (clar.c:433)
==17702==    by 0x4105E1: main (main.c:24)
As per CID:1378747, we might be called with a NULL repo, which would be deferenced in write_add_refspec
@pks-t pks-t merged commit 232dd4d into libgit2:master Apr 20, 2018
@pks-t
Copy link
Copy Markdown
Member

pks-t commented Apr 20, 2018

Thanks as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants