Skip to content

odb: mempack: fix leaking objects when freeing mempacks #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethomson merged 1 commit into from
Mar 29, 2018
Merged

odb: mempack: fix leaking objects when freeing mempacks #4602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
odb: mempack: fix leaking objects when freeing mempacks 
When a ODB mempack gets free'd, we take no measures at all to free its
contents, most notably the objects added to the database, resulting in a
memory leak. Call `git_mempack_reset` previous to freeing the ODB
structures themselves, which takes care of releasing all associated
data structures.
  • Loading branch information
@pks-t
pks-t committed Mar 29, 2018
commit b6276ae0915522b6add6ac2da9900a617515f0eb
1 change: 1 addition & 0 deletions src/odb_mempack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ static void impl__free(git_odb_backend *_backend)
{
struct memory_packer_db *db = (struct memory_packer_db *)_backend;

git_mempack_reset(_backend);
git_oidmap_free(db->objects);
git__free(db);
}
Expand Down