online::clone: validate user:pass in HTTP_PROXY#4556
Merged
Conversation
Validate using the http://user:pass@host/ format in HTTP_PROXY and HTTPS_PROXY environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate using the http://user:pass@host/ format in HTTP_PROXY and HTTPS_PROXY environment variables.
Note that we don't actually have a way to ensure that our proxy was contacted. So this test would pass even if there was a code error that meant that requests went direct to the server, bypassing the proxy.
I certainly don't have a proxy-neutral way to enforce that, offhand... I guess we could expose and endpoint in the remote code that will get headers back, and we could see if a
Viais set. That would probably be effective, but sort of ugh, and assumes that some transparent proxy doesn't add aViaheader itself.