Skip to content

examples: ls-files: add ls-files to list paths in the index #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pks-t merged 13 commits into from
May 4, 2018
Merged

examples: ls-files: add ls-files to list paths in the index #4380

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
30e919c
examples: ls-files: list files
Oct 16, 2017
991fc08
examples: ls-files: show current files in index
Oct 17, 2017
52d83dd
examples: ls-files: handle --error-unmatch
Oct 18, 2017
cd39273
examples: ls-files: fix style and refactor
cjhoward92 Oct 23, 2017
d2f99e0
examples: ls-files: fix compile error
cjhoward92 Oct 23, 2017
37cbc3e
examples: ls-files: build file list with array
Oct 23, 2017
3f64a9d
examples: ls-files: use git_array_t to handle files
Oct 26, 2017
e866116
examples: ls-files: address PR and style
Nov 14, 2017
ee14465
examples: ls-files: fix build error
Nov 14, 2017
7d07941
test: ls-files: remove dependency on git_array
Dec 19, 2017
29ca3f3
examples: ls-files: update print_paths to print all cases
Jan 6, 2018
d7394c3
examples: ls-files: print entry path only when entry is found
Mar 27, 2018
8aa437e
tests: ls-files: use puts instead of printf and fix typos
May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
examples: ls-files: build file list with array
  • Loading branch information
Carson Howard authored and Carson Howard committed Mar 27, 2018
commit 37cbc3eaf4f853de9e2b2d36563c11bac4af7a3b
18 changes: 9 additions & 9 deletions examples/ls-files.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@
* This example demonstrates the libgit2 index APIs to roughly
* simulate the output of `git ls-files`.
* `git ls-files` has many options and this currently does not show them.
*
*
* `git ls-files` base command shows all paths in the index at that time.
* This includes staged and committed files, but unstaged files will not display.
*
*
* This currently supports:
* - The --error-unmatch paramter with the same output as the git cli
Copy link
Copy Markdown
Member

@pks-t pks-t Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: there's one space too much here. I'd also put that whole supported/unsupported thing a little bit shorter: "This currently only supports default behaviour and the --error-unmatch option."

* - default ls-files behavior
*
*
* This currently does not support:
* - anything else
*
*
*/

typedef struct {
Expand Down Expand Up @@ -84,7 +84,7 @@ static int parse_options(ls_options *opts, int argc, char *argv[])
return 0;
}

static int print_paths(ls_options *opts, git_index *index)
static int print_paths(ls_options *opts, git_index *index)
{
int i;
const git_index_entry *entry;
Copy link
Copy Markdown
Member

@pks-t pks-t Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be scoped to the loop

Expand All @@ -109,8 +109,8 @@ static int print_paths(ls_options *opts, git_index *index)
int main(int argc, char *argv[])
{
ls_options opts;
git_repository *repo;
git_index *index;
git_repository *repo = NULL;
git_index *index = NULL;
const git_index_entry *entry;
size_t entry_count;
size_t i = 0;
Expand All @@ -121,10 +121,10 @@ int main(int argc, char *argv[])

git_libgit2_init();

if ((error = git_repository_open_ext(&repo, ".", 0, NULL)) != 0)
if ((error = git_repository_open_ext(&repo, ".", 0, NULL)) < 0)
goto cleanup;

if ((error = git_repository_index(&index, repo)) != 0)
if ((error = git_repository_index(&index, repo)) < 0)
goto cleanup;

/* if there are files explicitly listed by the user, we need to treat this command differently */
Expand Down