Use SOCK_CLOEXEC when creating sockets#4364
Merged
pks-t merged 1 commit intolibgit2:masterfrom Oct 6, 2017
Merged
Conversation
Member
|
Hi @andoma, thanks for your first PR! The change definitly looks sensible to me (even though the interface itself looks horrible, but that's to blame on backwards compatibility here with the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to how O_CLOEXEC is used for
open()libgit2 should also use SOCK_CLOEXEC (when available) for opening sockets.