Skip to content

tsort: remove idempotent conditional assignment #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethomson merged 1 commit into from
Jul 26, 2017
Merged

tsort: remove idempotent conditional assignment #4314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tsort: remove idempotent conditional assignment 
The conditional `run < minrun` can never be true directly after
assigning `run = minrun`. Remove it to avoid confusion.
  • Loading branch information
@pks-t
pks-t committed Jul 21, 2017
commit fdbb40fdd8b3a7337b9a354ca59039b19a50328a
1 change: 0 additions & 1 deletion src/tsort.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ static ssize_t collapse(void **dst, struct tsort_run *stack, ssize_t stack_curr,
#define PUSH_NEXT() do {\
len = count_run(dst, curr, size, store);\
run = minrun;\
if (run < minrun) run = minrun;\
if (run > (ssize_t)size - curr) run = size - curr;\
if (run > len) {\
bisort(&dst[curr], len, run, cmp, payload);\
Expand Down