Fix template dir empty string#4273
Merged
pks-t merged 3 commits intolibgit2:masterfrom Jun 21, 2017
azdavis:fix-template-dir-empty-string
Merged
Fix template dir empty string#4273pks-t merged 3 commits intolibgit2:masterfrom azdavis:fix-template-dir-empty-string
pks-t merged 3 commits intolibgit2:masterfrom
azdavis:fix-template-dir-empty-string
Conversation
pks-t
requested changes
Jun 19, 2017
Member
pks-t
left a comment
There was a problem hiding this comment.
Thanks for this PR, looks good besides some minor stylistic issues. Next to the comment, I'd propose you change your commit messages of 1c071c1 and 8cc25c7 to both include a "repository:" prefix. E.g.
repository: remove trailing whitespace
repository: do not initialize templates if dir is an empty string
| } | ||
|
|
||
| if (tdir) { | ||
| /* if tdir was the empty string, treat it like tdir was a path to an |
Member
There was a problem hiding this comment.
We usually avoid asymmetric comments. Instead, we start multiline comments with a sole "/*". Furthermore, the fisrt character should be upper-cased. E.g.
/*
* If tdir…
* …
*/
See e.g. 1 as a reference (except for C99-style "//" comments).
Contributor
Author
|
Thanks for the comments. I've made some changes. |
pks-t
approved these changes
Jun 21, 2017
Member
|
Thanks for the fixes and your PR! |
Member
|
Welcome to libgit2! Thanks for tackling this and congrats on getting your first libgit2 PR merged! 🎉
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4271.
This is my first time contributing to this project, so I hope I did everything correctly. I also added a test, which I verified does pass with the empty-string check I added, and fails otherwise.