settings: rename GIT_OPT_ENABLE_SYNCHRONOUS_OBJECT_CREATION#4259
Merged
ethomson merged 1 commit intolibgit2:masterfrom Jun 8, 2017
Merged
settings: rename GIT_OPT_ENABLE_SYNCHRONOUS_OBJECT_CREATION#4259ethomson merged 1 commit intolibgit2:masterfrom
GIT_OPT_ENABLE_SYNCHRONOUS_OBJECT_CREATION#4259ethomson merged 1 commit intolibgit2:masterfrom
Conversation
Initially, the setting has been solely used to enable the use of `fsync()` when creating objects. Since then, the use has been extended to also cover references and index files. As the option is not yet part of any release, we can still correct this by renaming the option to something more sensible, indicating not only correlation to objects. This commit renames the option to `GIT_OPT_ENABLE_FSYNC_GITDIR`. We also move the variable from the object to repository source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, the setting has been solely used to enable the use of
fsync()when creating objects. Since then, the use has been extendedto also cover references and index files. As the option is not yet part
of any release, we can still correct this by renaming the option to
something more sensible, indicating not only correlation to objects.
This commit renames the option to
GIT_OPT_ENABLE_FSYNC_GITDIR. We alsomove the variable from the object to repository source code.