Provide error on gcc < 4.1 when THREADSAFE#4135
Merged
Conversation
Member
Do you mean llvm/clang? The debugger surely isn't setting the defines. |
Provide a descriptive error message when compiling THREADSAFE on gcc versions < 4.1. We require the atomic primitives (eg `__sync_synchronize`) that were introduced in that version. (Note, clang setes `__GNUC__` but appears to set its version > 4.1.)
57ac11c to
aa5ea47
Compare
Member
Author
Yes, clearly. I've updated the commit message to reflect this. |
Member
|
The Travis build finished after 25m but it looks like it never sent out the notification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a descriptive error message when compiling
THREADSAFEon gcc versions < 4.1. We require the atomic primitives (eg__sync_synchronize) that were introduced in that version.(Note, clang setes
__GNUC__but appears to set its version > 4.1.)