Skip to content

[maint/v0.21] Fix build of tests with mingw#2770

Merged
ethomson merged 1 commit intolibgit2:maint/v0.21from
tkelman:patch-1
Dec 21, 2014
Merged

[maint/v0.21] Fix build of tests with mingw#2770
ethomson merged 1 commit intolibgit2:maint/v0.21from
tkelman:patch-1

Conversation

@tkelman
Copy link
Copy Markdown
Contributor

@tkelman tkelman commented Dec 21, 2014

very, very partial backport of 2f795d8 to maint/v0.21 branch

without this include (or equivalent in some other location), O_RDWR and O_CREAT are undeclared when building tests/path/win32.c with mingw

ref #2766 for discussion

very, very partial backport of 2f795d8 to maint/v0.21 branch

without this include, O_RDWR and O_CREAT are undeclared when building tests/path/win32.c with mingw
@ethomson
Copy link
Copy Markdown
Member

👍 Thanks for this! I was just lurching around trying to figure out why my mingw environment didn't work. I'm exceptionally thankful to not have to do this.

🌟 🌟 🌟

ethomson added a commit that referenced this pull request Dec 21, 2014
[maint/v0.21] Fix build of tests with mingw
@ethomson ethomson merged commit 8de0f1e into libgit2:maint/v0.21 Dec 21, 2014
@tkelman tkelman deleted the patch-1 branch December 21, 2014 03:37
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Dec 21, 2014

HTH. cmn figured out most of what was wrong the other day in #2766. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants