fix: CMake example commands in README.md - #29
Merged
Conversation
The format of `target_include_directories` has changed in the recent CMake versions (3.5 and higher) 'target_link_libraries' had a typo Minor fix: "apt-get" is generally preferred over aptitude for Ubuntu Thank you!
Owner
|
I think nowadays, "apt" is actually the preferred version ;) Anyways, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format of
target_include_directorieshas changed in the recent CMake versions (3.5 and higher)'target_link_libraries' had a typo
Minor fix: "apt-get" is generally preferred over aptitude for Ubuntu
Thank you!