Skip to content

test: refactor database version time to prevent flakiness #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larkee merged 4 commits into from
Jan 27, 2021
Merged

test: refactor database version time to prevent flakiness #3

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
466ef3c
Remove unnecessary retention period setting
zoercai Jan 22, 2021
413dbc9
Fix systests
zoercai Jan 25, 2021
ffd0b91
Merge branch 'pitr-support' of github.com:larkee/python-spanner into …
zoercai Jan 27, 2021
aa7a27a
Review changes
zoercai Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unnecessary retention period setting
  • Loading branch information
@zoercai
zoercai committed Jan 22, 2021
commit 466ef3cadcc2d3ac94c21a1eb4beb3c4b22e398d
16 changes: 0 additions & 16 deletions tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,22 +600,6 @@ def setUpClass(cls):
op1.result(30) # raises on failure / timeout.
op2.result(30) # raises on failure / timeout.

# Add retention period for backups
retention_period = "7d"
ddl_statements = DDL_STATEMENTS + [
"ALTER DATABASE {}"
" SET OPTIONS (version_retention_period = '{}')".format(
cls.DATABASE_NAME, retention_period
)
]
db = Config.INSTANCE.database(
cls.DATABASE_NAME, pool=pool, ddl_statements=ddl_statements
)
operation = db.update_ddl(ddl_statements)
# We want to make sure the operation completes.
operation.result(240) # raises on failure / timeout.
db.reload()

current_config = Config.INSTANCE.configuration_name
same_config_instance_id = "same-config" + unique_resource_id("-")
create_time = str(int(time.time()))
Expand Down