Repository navigation
Conversation
deveworld
left a comment
There was a problem hiding this comment.
setDatabase copies the default into autoSuggestPrompt (database.svelte.ts:354), so existing users keep the English-only prompt. Also, UI language can differ from chat language. "the conversation's language" might be safer.
d05dc7f to
6696a0e
Compare
|
Thanks for the review @deveworld! Both points addressed (history rewritten into two commits):
P.S. Risu is really great to use — I'll keep contributing. Feel free to reach out anytime if anything comes up! |
deveworld
left a comment
There was a problem hiding this comment.
LGTM!
nit: presets also store autoSuggestPrompt, so switching to an older preset brings the legacy prompt back. Migrating it in the botPresets loop in setDatabase would cover that.
|
Thanks for the thorough review! All the requested changes are in now — if there's anything else, just let me know and I'll fix it right away. |
Problem
The default auto suggestion prompt hardcodes
print it out in English only, so auto suggestions are always generated in English regardless of what language the roleplay is written in. Non-English users either get suggestions in the wrong language or have to enable the translate toggle and pay an extra translation request per suggestion.Changes
setDatabasecopies the default intoautoSuggestPrompton existing databases, a migration replaces the stored legacy default with the new default when it matches verbatim; customized prompts are untouched (thanks @deveworld for catching this).