Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Fix data decode for watch/watch.py:49#137

Closed
dbazhal wants to merge 1 commit into
kubernetes-client:masterfrom
dbazhal:master
Closed

Fix data decode for watch/watch.py:49#137
dbazhal wants to merge 1 commit into
kubernetes-client:masterfrom
dbazhal:master

Conversation

@dbazhal

@dbazhal dbazhal commented Jun 20, 2019

Copy link
Copy Markdown

There is error like

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in position 2047: unexpected end of data
<...>
  File "kubernetes/watch/watch.py", line 134, in stream
    for line in iter_resp_lines(resp):
  File "kubernetes/watch/watch.py", line 49, in iter_resp_lines
    seg = seg.decode('utf8')

So this PR fixes that. Related somehow to #104

@k8s-ci-robot

k8s-ci-robot commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
k8s-ci-robot requested review from roycaihw and yliaog June 20, 2019 18:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 20, 2019
@dbazhal dbazhal mentioned this pull request Jun 20, 2019
Merged
@dbazhal

dbazhal commented Jun 20, 2019

Copy link
Copy Markdown
Author

/assign roycaihw

@dbazhal Dmitry Bazhal
Fix ```UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in po…
cf35bca 
…sition 2047: unexpected end of data``` on kubernetes/watch/watch.py:49
@k8s-ci-robot

k8s-ci-robot commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dbazhal
To complete the pull request process, please assign roycaihw
You can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dbazhal

dbazhal commented Jun 20, 2019

Copy link
Copy Markdown
Author

Much sorry, messed up with commit author and git history... Will recreate this PR again.

@dbazhal dbazhal closed this Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw
@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbazhal @k8s-ci-robot @roycaihw