Added Ingress Example#933
Conversation
|
/assign @yliaog |
micw523
left a comment
There was a problem hiding this comment.
I believe extensions v1 beta1 API deployments are going to be totally phased out by k8s v1.16. Could you use newer APIs instead?
| def create_deployment(extensions_v1_beta1): | ||
| container = client.V1Container( | ||
| name="deployment", | ||
| image="ratanboddu/flaskapp:basic", |
There was a problem hiding this comment.
better to have the image from gcr.io?
| replicas=1, | ||
| template=template) | ||
| # Deployment | ||
| deployment = client.ExtensionsV1beta1Deployment( |
There was a problem hiding this comment.
should use V1, deployment has GA already
| # Fetching and loading local Kubernetes Information | ||
| config.load_kube_config() | ||
| # For incluster details | ||
| # config.load_incluster_config() |
There was a problem hiding this comment.
remove the above commented out line?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ratanboddu, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this example does :